markcyoung
Tested and confirmed. Nice work!
turnermm
Thanks for testing this. I've merged the changes into 4.9-tinker, which is the current ckgedit distribution, as I mentioned above, i.e the distribution which the extension manager installs. But it is also still in the master, which will eventually be merged with 4.9-tinker.
homer83
I think because of this change the dialog for typing the tags does not popup anymore.
The Version
https://github.com/turnermm/ckgedit/archive/merger49.3.zip is still working.
The newer ones and the actual master causes an exception in ckeditor.js:
Exception
:
TypeError: Cannot read property 'charAt' of undefined at new <anonymous> (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:546:421) at Object.build (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:528:922) at Object.build (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:629:488) at Object.build (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:629:488) at CKEDITOR.dialog.addPage (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:602:443) at new CKEDITOR.dialog (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:591:339) at a.openDialog (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:634:134) at a.<anonymous> (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:634:497) at e (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:250:177) at Array.z (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:250:332)
message
:
"Cannot read property 'charAt' of undefined"
stack
:
"TypeError: Cannot read property 'charAt' of undefined↵ at new <anonymous> (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:546:421)↵ at Object.build (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:528:922)↵ at Object.build (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:629:488)↵ at Object.build (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:629:488)↵ at CKEDITOR.dialog.addPage (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:602:443)↵ at new CKEDITOR.dialog (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:591:339)↵ at a.openDialog (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:634:134)↵ at a.<anonymous> (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:634:497)↵ at e (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:250:177)↵ at Array.z (https://XXX/lib/plugins/ckgedit/ckeditor/ckeditor.js:250:332)"
turnermm
Are you referring to the tags popup? Which browser?
turnermm
Sorry, the above was from my phone.
If you are referring to the current distribution of ckgedit, which is installed form the extension manager, that version uses CKEditor 4.9, while the previous uses 4.7. If you have just upgraded to 4.9 from 4.7, I suggest you clear out your browser cache.
Which browser(s) are you using? The output that you supply doesn't help because it refers to a compressed javascript file. I've tested this with firefox, Opera, and chrome, both their latest versions. Chrome Version 69.0.3497.92, Firefox 62.0, Chrome 55.0.2994.56.
These are all on Windows. Abut also an older version of Safari on a Mac. I can't reproduce the error. So browser and operating system would help.
turnermm
I can add firefox 60.1 on Centos Linux to the above.
homer83
Sorry for the late answer. I was on holidays.
Yes i am referring to the tags popup.
I've just installed the latest Version from 2018-09-20 and cleared the browser cache.
It's still the same problem here.
I tried
- chrome browser 69 and Internet Explorer 11 and Firefox 62 on Win10 and
- Firefox 62, Internet Explorer 11 on Win7.
Is there anything I can do to help for locating the problem?
homer83
Maybe this helps:
All other buttons / plugins work as expected.
I tried the button for word plugin, geshi snippet, wrap-plugin. The page gets dark and the popup shows up.
But after pressing the button for the tag plugin, the page gets dark and nothing happens.
turnermm
This has been tested by @markcyoung and verified, as well as by me on a variety of platforms and configurations, i.e. placing the tags at the bottom or top of the page. Not sure what your problem is.
homer83
I've just updated to the latest version. It works.
But I have a little addition.
The text of the label "Place tags at: " is hard coded in tags.js
Thats why I inserted the new element radioLabel in de.js and en.js :-)
Not a big thing and i can live with it.
homer83
Ok i've found the problem:
We use the german language and the file
../ckeditor/plugins/tags/lang/de.js
differs from
../ckeditor/plugins/tags/lang/en.js.
In the german language file the elements info, bottom, cursor and top are not set.
turnermm
Perhaps you can provide the translations, and I will include them in an update to the ckgedit plugin. There is a lot of information about ckgedit on the plugin site at dokuwiki.org which makes it sometimes difficult to navigate, though I've tried my best by providing an index. Anyway, see
language support and localization, in particular the section on
plugins.
turnermm
Your problem has called attention to something I was not aware of, which is that the new style CKEditor localization for plugins does not default to English. Still, you should only have found an 'undefined' in place of the missing langauge strings, so that I don't know what happened in the German language file, despite repeated testing. I can do some translation from English to German but I don't trust my idiomatic grasp of German.
Now that I am aware of this, I've made some changes so that the problem you have had will not repeat in the other plugins where I have followed this scheme.
homer83
I've send you a PM with my changes.
Thank you for your work!
turnermm
Thanks. I've merged it into ckgedit master.
turnermm
Right, I didn't see that. It's done.