This morning I was testing something, running dokuwiki from Git with the latest master branch checked out.
I was surprised to get the Hotfix release available: 2024-02-06a "Kaos". upgrade now! [55.1] (what's this?) alert, which IMO does not really make sense when running from Git, and even if it did, I would expect not to see the alert anyway since master branch HEAD is more recent than stable (where the variable was updated in commit https://github.com/dokuwiki/dokuwiki/commit/f9a1621a2a7954fefccb5c87ddf16bf9364ccd40).
The obvious, easy fix is to update the assignment, like this has apparently been done (manually? ) in the past
diff --git a/doku.php b/doku.php
index 078f9b8b7..8f09e916a 100644
--- a/doku.php
+++ b/doku.php
@@ -13,7 +13,7 @@ use dokuwiki\ChangeLog\PageChangeLog;
use dokuwiki\Extension\Event;
// update message version - always use a string to avoid localized floats!
-$updateVersion = "55";
+$updateVersion = "56";
// xdebug_start_profiling();
and while I certainly could send a PR for that, I was wondering if
- If it would make sense to simply ignore the version check when running from Git
- Bumping this value is not something that should be somehow automated as part of your release process (i.e. += 1 when a new major version goes live (AFAICT this is a manual process for now)
Note: I'm aware that this is being done in the current branch (https://github.com/dregad/dokuwiki/commit/66966f8dc7ed5b2244a68ce5e46a8c5294a13794), what I'm suggesting is to also bump it in master branch.
I can't really help with point 2 as I'm not familiar with Github actions and have no idea where the env.next_update
variable is being set and how, but if 1 is of interest I can probably provide a PR.