Not logged in. · Lost password · Register
Forum: Community dokuwiki.org RSS
extra slash in opening <button> tag
Avatar
Carsten #1
Member since Feb 2011 · 12 posts · Location: Germany
Group memberships: Members
Show profile · Link to this post
Subject: extra slash in opening <button> tag
Hi all,

being logged in at https://www.dokuwiki.org, looking at e.g. https://www.dokuwiki.org/features, the Edit buttons seem to have an extra slash at the end of the opening <button> tags, e.g.

<button type="submit" title="DokuWiki Features" />Edit</button>

A (known) bug?

Best regards,
Carsten
Avatar
SFITCS #2
User title: Scott Ferguson
Member since Dec 2014 · 463 posts · Location: Canberra, Australia
Group memberships: Members
Show profile · Link to this post
Interesting!

The invalid HTML only shows when someone is logged in. See attachment (it's valid source when you're not logged in).
Avatar
Carsten #3
Member since Feb 2011 · 12 posts · Location: Germany
Group memberships: Members
Show profile · Link to this post
Hi,
I cannot see the attachment that you're referring to, but as the code that I mentioned is about the Edit buttons, which are only rendered when the user is logged in, it seems quite obvious that this problem cannot be seen when not logged in.  :-)

Best regards,
Carsten
Avatar
andi (Administrator) #4
User title: splitbrain
Member since May 2006 · 3358 posts · Location: Berlin Germany
Group memberships: Administrators, Members
Show profile · Link to this post
Well spotted. Fixed in https://github.com/splitbrain/dokuwiki/commit/9c65e2a95c67…
Read this if you don't get any useful answers.
Lies dies wenn du keine hilfreichen Antworten bekommst.
Avatar
SFITCS #5
User title: Scott Ferguson
Member since Dec 2014 · 463 posts · Location: Canberra, Australia
Group memberships: Members
Show profile · Link to this post
In reply to post #3
Quote by Carsten:
I cannot see the attachment that you're referring to

Sorry - it didn't upload for some reason http://ge.tt/3JCqWEW2/v/0

Quote by Carsten:
, but as the code that I mentioned is about the Edit buttons, which are only rendered when the user is logged in,

No. Anyone can modify those pages so the edit buttons are always visible (http://ge.tt/4n0hYEW2/v/0?c not too difficult to check?).

Quote by Carsten:
it seems quite obvious that this problem cannot be seen when not logged in.  :-)

Seems obvious... (but I think you'll find it's not that simple)
:)

Fixed now, all good.
Avatar
Carsten #6
Member since Feb 2011 · 12 posts · Location: Germany
Group memberships: Members
Show profile · Link to this post
In reply to post #4
Gee, thanks!   :-)

Quote by SFITCS:
Anyone can modify those pages so the edit buttons are always visible

Ah, sorry. I only noticed that the problem was with the Edit buttons, and didn't really bother to check login vs. logout (and my DokuWiki instance is differently configured ;-) ).
Close Smaller – Larger + Reply to this post:
Verification code: VeriCode Please enter the word from the image into the text field below. (Type the letters only, lower case is okay.)
Smileys: :-) ;-) :-D :-p :blush: :cool: :rolleyes: :huh: :-/ <_< :-( :'( :#: :scared: 8-( :nuts: :-O
Special characters:
Go to forum
Imprint
This board is powered by the Unclassified NewsBoard software, 20150713-dev, © 2003-2015 by Yves Goergen
Current time: 2018-12-14, 23:07:37 (UTC +01:00)